Add an Extras field on the compose config types.#1126
Merged
vdemeester merged 1 commit intodocker:masterfrom Jun 25, 2018
Merged
Add an Extras field on the compose config types.#1126vdemeester merged 1 commit intodocker:masterfrom
Extras field on the compose config types.#1126vdemeester merged 1 commit intodocker:masterfrom
Conversation
Contributor
|
Should'nt we generalize that on every object (including portsconfig etc.) ? |
Collaborator
Author
|
@simonferquel in this PR, it's only on object that are allowed to have |
thaJeztah
approved these changes
Jun 23, 2018
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
ping @silvin-lubecki @dnephin PTAL
dnephin
approved these changes
Jun 24, 2018
cli/compose/loader/loader.go
Outdated
| return serviceConfig, nil | ||
| } | ||
|
|
||
| func handleExtras(name string, source map[string]interface{}) map[string]interface{} { |
Contributor
There was a problem hiding this comment.
nit: loadExtras might be more consistent with existing naming
That field is automaticaly populated with any `x-*` field in the yaml. And marshalling the compose config struct put them back into place. This make it possible to get those extra fields without re-inventing the wheel (i.e. reimplementing 80% of the `cli/compose/*` packages. Signed-off-by: Vincent Demeester <vincent@sbr.pm>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That field is automaticaly populated with any
x-*field in the yaml.And marshalling the compose config struct put them back into place.
This make it possible to get those extra fields without re-inventing
the wheel (i.e. reimplementing 80% of the
cli/compose/*packages.Will be very useful for experiments in
docker/app👼Signed-off-by: Vincent Demeester vincent@sbr.pm