Remove "experimental" annotations for buildkit#1303
Conversation
BuildKit can now be enabled without the daemon having experimental features enabled. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
ping @andrewhsu @tiborvass @AntaresS PTAL |
| flags.SetAnnotation("progress", "experimental", nil) | ||
|
|
||
| flags.StringArrayVar(&options.secrets, "secret", []string{}, "Secret file to expose to the build (only if BuildKit enabled): id=mysecret,src=/local/secret") | ||
| flags.SetAnnotation("secret", "experimental", nil) |
There was a problem hiding this comment.
Wonder if we should have a new annotation to hide / disable these if the CLI (or daemon) is configured to use builder v1
There was a problem hiding this comment.
you mean hide the progress and secret flags?
There was a problem hiding this comment.
probably better when builder v1 is configured on the cli side
There was a problem hiding this comment.
Yes; not a blocker for now, but would be good to look into
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov Report
@@ Coverage Diff @@
## master #1303 +/- ##
==========================================
- Coverage 54.77% 54.76% -0.02%
==========================================
Files 292 292
Lines 19285 19285
==========================================
- Hits 10563 10561 -2
- Misses 8063 8064 +1
- Partials 659 660 +1 |
|
Pushed a second commit to move "sessions" out of experimental as well (per moby/moby#37686) |
|
@tiborvass should the cli/cli/command/image/build.go Lines 153 to 154 in 2461cd6 |
| const clientSessionRemote = "client-session" | ||
|
|
||
| func isSessionSupported(dockerCli command.Cli) bool { | ||
| if versions.GreaterThanOrEqualTo(dockerCli.Client().ClientVersion(), "1.39") { |
There was a problem hiding this comment.
This should check daemon version, not CLI.
There was a problem hiding this comment.
Daemon could be version 1.40, but the client downgraded to 1.10; in that case the API version that's used is 1.10, and it's not supported
tiborvass
left a comment
tiborvass
left a comment
There was a problem hiding this comment.
we should check daemon version not cli
5 participants
BuildKit can now be enabled without the daemon having experimental features enabled.
related engine PR; moby/moby#37686