[master] Update "deb" packaging to use "dh_installsystemd", and remove upstart script#914
Merged
neersighted merged 1 commit intodocker:masterfrom Jul 21, 2023
Merged
Conversation
thaJeztah
force-pushed
the
debhelper_update_take_2
branch
from
2b87537 to
fb8e299
Compare
tianon
reviewed
Jun 21, 2023
Contributor
tianon
left a comment
tianon
left a comment
There was a problem hiding this comment.
Generally I like the shape, just a few suggestions ❤️
neersighted
previously requested changes
Jul 5, 2023
Member
neersighted
left a comment
neersighted
left a comment
There was a problem hiding this comment.
LGTM with @tianon's tweaks
neersighted
force-pushed
the
debhelper_update_take_2
branch
from
fb8e299 to
29682a9
Compare
Member
|
Applied the review comments; @tianon @thaJeztah PTAL |
tianon
reviewed
Jul 20, 2023
This reverts commit cafc21c. This also removes the now-obsolete upstart script and updates the "debhelper compat level" to 12 (which necessitates adding "override_dh_dwz" -- safe to remove once we can update to debhelper-compat 13+). (See also https://lists.debian.org/debian-devel-announce/2020/02/msg00000.html) Signed-off-by: Tianon Gravi <admwiggin@gmail.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: Bjorn Neergaard <bjorn.neergaard@docker.com>
neersighted
force-pushed
the
debhelper_update_take_2
branch
from
29682a9 to
5c01d5b
Compare
tianon
approved these changes
Jul 20, 2023
Contributor
tianon
left a comment
tianon
left a comment
There was a problem hiding this comment.
Technically the -1 is unnecessarily specific, but should be harmless. LGTM 👍 ❤️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit cafc21c.
This also removes the now-obsolete upstart script and updates the "debhelper compat level" to 12 (which necessitates adding "override_dh_dwz" -- safe to remove once we can update to debhelper-compat 13+).
(See also https://lists.debian.org/debian-devel-announce/2020/02/msg00000.html)