Fix lack of col field in bandit breaking linter output#16337
Merged
Conversation
This was referenced May 28, 2021
tonybaloney
marked this pull request as ready for review
May 28, 2021 00:56
Author
|
@karthiknadig for review please. think this is a clean fix + some tests for regression |
|
I like this better then #16336 |
|
This will solve #15561 |
karrtikr
approved these changes
May 28, 2021
karrtikr
left a comment
karrtikr
left a comment
There was a problem hiding this comment.
Thanks for the fix! Please add a news entry.
paulacamargo25
approved these changes
May 31, 2021
paulacamargo25
left a comment
paulacamargo25
left a comment
There was a problem hiding this comment.
LGTM, im not sure if the "Use of insecure SSL/TLS version" warning can be solve?
karthiknadig
approved these changes
Jun 1, 2021
Member
|
@paulacamargo25 that seems to be in different part of the code not related to this PR. |
karthiknadig
reviewed
Jun 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15561