Makes a few modifications to the name generator.#38422
Merged
fntlnz merged 1 commit intomoby:masterfrom Jan 23, 2019
Merged
Conversation
* Replaces `cocks` with `cerf` as the former might be perceived as offensive by some people (as pointed out by @jeking3 [here](moby#37157 (comment))) * Removes a duplicate entry for `burnell` * Re-arranges the entry for `sutherland` to ensure that the names are in sorted order * Adds entries for `shamir` and `wilbur` Signed-off-by: Debayan De <debayande@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #38422 +/- ##
==========================================
+ Coverage 36.54% 36.56% +0.01%
==========================================
Files 608 608
Lines 45036 45036
==========================================
+ Hits 16460 16466 +6
+ Misses 26295 26291 -4
+ Partials 2281 2279 -2 |
Member
She was in there twice 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Made a few modifications to the name generator
How I did it
I made the modifications in question to
pkg/namesgenerator/names-generator.goHow does one verify it
Please check
pkg/namesgenerator/names-generator.goA description for the changelog
cockswithcerfas the former might be perceived asoffensive by some people (as pointed out by @jeking3
here)
burnellsutherlandto ensure that the names are insorted order
shamirandwilburA picture of a cute animal (not mandatory but encouraged)
Signed-off-by: Debayan De debayande@users.noreply.github.com